Skip to content

SCTP part 9#1782

Merged
ibc merged 25 commits into
v3from
sctp-part-9
Apr 24, 2026
Merged

SCTP part 9#1782
ibc merged 25 commits into
v3from
sctp-part-9

Conversation

@ibc

@ibc ibc commented Apr 22, 2026

Copy link
Copy Markdown
Member

Details

  • OutstandingData class.
  • RetransmissionQueue class.
  • Fixes.

@ibc

ibc commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

TODO 1: Crash when closing a DataProducer in client

UPDATE: Fixed here a921b55.

STR: In the mediasoup-demo in browser in console run CHAT_DATA_PRODUCER.close().

  mediasoup:Worker (stdout) RTC::SCTP::Association::ReceiveSctpData() | <<< received SCTP packet: +8s
  mediasoup:Worker (stdout) <SCTP::Packet> +0ms
  mediasoup:Worker (stdout)   length: 36 (buffer length: 36) +0ms
  mediasoup:Worker (stdout)   source port: 5000 +0ms
  mediasoup:Worker (stdout)   destination port: 5000 +0ms
  mediasoup:Worker (stdout)   verification tag: 2290873334 +0ms
  mediasoup:Worker (stdout)   checksum: 1955520800 +0ms
  mediasoup:Worker (stdout)   chunks count: 1 +0ms
  mediasoup:Worker (stdout)   <SCTP::ReConfigChunk> +0ms
  mediasoup:Worker (stdout)     type: 130 (RE_CONFIG) (unknown: no) +0ms
  mediasoup:Worker (stdout)     flags: 00000000 +0ms
  mediasoup:Worker (stdout)     length field: 22 (padding: 2, buffer length: 24) +0ms
  mediasoup:Worker (stdout)     parameters count: 1 +1ms
  mediasoup:Worker (stdout)     <SCTP::OutgoingSsnResetRequestParameter> +0ms
  mediasoup:Worker (stdout)       type: 13 (OUTGOING_SSN_RESET_REQUEST) (unknown: no) +0ms
  mediasoup:Worker (stdout)       length field: 18 (padding: 2, buffer length: 20) +0ms
  mediasoup:Worker (stdout)       re-configuration request sequence number: 3993100831 +0ms
  mediasoup:Worker (stdout)       re-configuration response sequence number: 3993100831 +0ms
  mediasoup:Worker (stdout)       sender last assigned tsn: 3993100830 +0ms
  mediasoup:Worker (stdout)       stream ids: +0ms
  mediasoup:Worker (stdout)       - stream id: 0 +0ms
  mediasoup:Worker (stdout)     </SCTP::OutgoingSsnResetRequestParameter> +0ms
  mediasoup:Worker (stdout)   </SCTP::ReConfigChunk> +0ms
  mediasoup:Worker (stdout) </SCTP::Packet> +0ms
  mediasoup:Worker (stdout) RTC::SCTP::Association::MayConnect() | internal Association state is not NEW, ignoring +1ms
  mediasoup:Worker (stdout) RTC::SCTP::PacketSender::SendPacket() | >>> sending SCTP packet: +0ms
  mediasoup:Worker (stdout) <SCTP::Packet> +0ms
  mediasoup:Worker (stdout)   length: 28 (buffer length: 1191) +0ms
  mediasoup:Worker (stdout)   source port: 5000 +0ms
  mediasoup:Worker (stdout)   destination port: 5000 +0ms
  mediasoup:Worker (stdout)   verification tag: 3888951330 +0ms
  mediasoup:Worker (stdout)   checksum: 751134860 +0ms
  mediasoup:Worker (stdout)   chunks count: 1 +0ms
  mediasoup:Worker (stdout)   <SCTP::ReConfigChunk> +0ms
  mediasoup:Worker (stdout)     type: 130 (RE_CONFIG) (unknown: no) +0ms
  mediasoup:Worker (stdout)     flags: 00000000 +0ms
  mediasoup:Worker (stdout)     length field: 16 (padding: 0, buffer length: 16) +0ms
  mediasoup:Worker (stdout)     parameters count: 1 +0ms
  mediasoup:Worker (stdout)     <SCTP::ReconfigurationResponseParameter> +0ms
  mediasoup:Worker (stdout)       type: 16 (RECONFIGURATION_RESPONSE) (unknown: no) +0ms
  mediasoup:Worker (stdout)       length field: 12 (padding: 0, buffer length: 12) +0ms
  mediasoup:Worker (stdout)       re-configuration response sequence number: 3993100831 +0ms
  mediasoup:Worker (stdout)       result: 0 (SUCCESS_NOTHING_TO_DO) +0ms
  mediasoup:Worker (stdout)       has next tsns: no +0ms
  mediasoup:Worker (stdout)     </SCTP::ReconfigurationResponseParameter> +0ms
  mediasoup:Worker (stdout)   </SCTP::ReConfigChunk> +0ms
  mediasoup:Worker (stdout) </SCTP::Packet> +0ms
  mediasoup:ERROR:Worker (stderr) (ABORT) RTC::SCTP::StreamResetHandler::CreateReconfigChunk() | failed assertion `this->currentRequest.has_value()`: currentRequest optional must have value undefined +0ms
  mediasoup:Channel Consumer Channel ended by the worker process +38s

@ibc ibc marked this pull request as ready for review April 23, 2026 11:45
@ibc ibc marked this pull request as draft April 23, 2026 11:46

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated
Comment thread worker/src/RTC/SCTP/tx/RetransmissionQueue.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread worker/src/RTC/SCTP/association/TransmissionControlBlock.cpp Outdated
@ibc ibc marked this pull request as ready for review April 24, 2026 11:08
@ibc ibc requested a review from jmillan April 24, 2026 11:09
@ibc ibc merged commit 9b84c0b into v3 Apr 24, 2026
43 checks passed
@ibc ibc deleted the sctp-part-9 branch April 24, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant